I guess I don't understand the vitriol this topic always causes. There is literally nothing wrong with doing something nice for someone. I understand the crew quarters are small, and I'd never give a gift that would take their valuable space, but a box of candy with a tip inside?
Yes, I know they have access to snacks, but I have access to a diamond tennis bracelet. I'm not turning one down if offered.
By the way, here's a shot of the goody bags I made for the breakfast room service attendants on my last cruise. Simple and easy to either throw away or give to someone else.