Funny. I've not seen shorts in Terrace for dinner. Breakfast & lunch, yes, but not dinner. This has been on Riviera.
NJhorseman & a few others seem to harp a lot about wearing what is or is not proper for dinner. Simple as this: Nice Khaki type long pants & a nice button down shirt(long or shortsleeve) NO ties, but a sport coat for the specialties(especially Jacques). On our Jan. 14 cruise on Riviera there was a gentleman who dressed in a top notch vested suit. A little over the top, but looked great.